Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct calculation of padding in percent #5846

Merged
merged 2 commits into from
Nov 21, 2018
Merged

Correct calculation of padding in percent #5846

merged 2 commits into from
Nov 21, 2018

Conversation

chtheis
Copy link
Contributor

@chtheis chtheis commented Nov 18, 2018

Fixes a bug introduced with #4620

@simonbrunel simonbrunel added this to the Version 2.8 milestone Nov 19, 2018
@simonbrunel
Copy link
Member

@chtheis thanks for the fix. As you said in #4620, the unit test uses 10%, which actually work with the previous code (x / 10 === x * 10 / 100). Can you update the unit test with a better value?

@chtheis
Copy link
Contributor Author

chtheis commented Nov 19, 2018

Done

simonbrunel
simonbrunel approved these changes Nov 21, 2018
View reviewed changes
Copy link
Member

@simonbrunel simonbrunel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chtheis

@simonbrunel simonbrunel merged commit b68341d into chartjs:master Nov 21, 2018
@snyk-bot snyk-bot mentioned this pull request Nov 9, 2019
Merged
This was referenced Mar 4, 2020
Open
Open
@vpetersson vpetersson mentioned this pull request Mar 7, 2020
Merged
This was referenced Mar 9, 2020
Closed
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
This was referenced Apr 14, 2020
Open
Open
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
@chtheis @simonbrunel
Correct calculation of padding in percent (chartjs#5846)
ddc59a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

@simonbrunel simonbrunel simonbrunel approved these changes

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
Version 2.8
Development

Successfully merging this pull request may close these issues.
3 participants
@chtheis @simonbrunel @etimberg